Skip to content

FIX Revert tarfile_extractall clean-up #31685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jeremiedbb
Copy link
Member

@jeremiedbb jeremiedbb commented Jul 1, 2025

Fixes #31521
Closes #31523

tarfile_extractall was removed in 1.7 because we thought that the filter arg was added in Python 3.10 but it turns out that only Python 3.12 has it from the start (3.12.0). Previous versions introduced it as part of a micro version.

@jeremiedbb jeremiedbb added this to the 1.7.1 milestone Jul 1, 2025
@jeremiedbb jeremiedbb added To backport PR merged in master that need a backport to a release branch defined based on the milestone. Quick Review For PRs that are quick to review labels Jul 1, 2025
Copy link

github-actions bot commented Jul 1, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 472144d. Link to the linter CI: here

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only thing we need is a changelog entry for a bug fix release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:datasets module:utils Quick Review For PRs that are quick to review To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TarFile.extractall() got an unexpected keyword argument 'filter'
2 participants