Skip to content

Another set of fixes fixes for the graph/state machine generation functionality #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

Another set of fixes fixes for the graph/state machine generation functionality #34

merged 2 commits into from
Jul 2, 2025

Conversation

oEscal
Copy link
Contributor

@oEscal oEscal commented Jul 1, 2025

This PR adds multiple bug fixes for the feature implemented in #30:

  • The initial state of the state machine was obtained as the first state listed in the workflow. This was because the code in the TypeScript SDK was implemented in this manner. Now, the code checks for the start state.
  • Whenever a parallel state was the first one in the workflow, the state machine generator would throw an error. This was because the code was not creating the state in that specific case.

oEscal added 2 commits July 1, 2025 16:38
@oEscal
detecting the initial state fixed; fixed parallel machine state creat…
c88a382 
…ion when it is the first state in the machine

Signed-off-by: Pedro Escaleira <pedroescaleira@hotmail.com>
@oEscal
Merge branch 'main' into bug/wf-initial-graph
98fbd74
@oEscal
Copy link
Contributor Author

oEscal commented Jul 1, 2025

@cdavernas I am very sorry for these late changes, but I am detecting these bugs as I am testing weirder things using the SDK.

@cdavernas
Copy link
Member

@oEscal Come on, no worries! Thanks for your awesome contributions!

cdavernas
cdavernas approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers ❤️

@cdavernas cdavernas merged commit fd4379f into serverlessworkflow:main Jul 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdavernas cdavernas cdavernas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oEscal @cdavernas