Upgrade natives from 1.1.4 to 1.1.6 to fix ‘npm install’ on Node ≥ 10.15.0 #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, ‘npm install’ fails on Node ≥ 10.15.0 (to say nothing of
12.x or 14.x, which Gulp 3 doesn’t support at all):
$ npm install
> stacktrace-js@2.0.2 prepare /home/anders/js/stacktrace.js
> gulp dist
internal/util/inspect.js:31
const types = internalBinding('types');
^
ReferenceError: internalBinding is not defined
at internal/util/inspect.js:31:15
at req_ (/home/anders/js/stacktrace.js/node_modules/natives/index.js:137:5)
at require (/home/anders/js/stacktrace.js/node_modules/natives/index.js:110:12)
at util.js:25:21
at req_ (/home/anders/js/stacktrace.js/node_modules/natives/index.js:137:5)
at require (/home/anders/js/stacktrace.js/node_modules/natives/index.js:110:12)
at fs.js:42:21
at req_ (/home/anders/js/stacktrace.js/node_modules/natives/index.js:137:5)
at Object.req [as require] (/home/anders/js/stacktrace.js/node_modules/natives/index.js:54:10)
at Object.<anonymous> (/home/anders/js/stacktrace.js/node_modules/vinyl-fs/node_modules/graceful-fs/fs.js:1:37)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! stacktrace-js@2.0.2 prepare: `gulp dist`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the stacktrace-js@2.0.2 prepare script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/anders/.npm/_logs/2021-03-25T00_14_18_635Z-debug.log
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without this,
npm installfails on Node ≥ 10.15.0 (to say nothing of 12.x or 14.x, which Gulp 3 doesn’t support at all):Types of changes
Checklist:
node_modules/.bin/jscs -c .jscsrc stacktrace.jspasses without errorsnpm testpasses without errors