Skip to content

Add new parameter as rememberGooglePayLauncher #10950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

winter-love-dev
Copy link

@winter-love-dev winter-love-dev commented Jun 13, 2025

Summary

Added optional publishableKey parameter to rememberGooglePayLauncher() to allow direct key specification without modifying singleton configuration.

Motivation

Eliminates need to reinitialize PaymentConfiguration singleton when switching between different country-specific publishable keys, reducing code complexity and preventing potential race conditions.

Testing

  • Added tests
  • Modified tests
  • Manually verified

@winter-love-dev winter-love-dev requested review from a team as code owners June 13, 2025 13:49
Copy link

cla-assistant bot commented Jun 13, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
Copy link

cla-assistant bot commented Jun 13, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tianzhao-stripe
Copy link
Contributor

Hi @winter-love-dev

Thanks for your contribution, we've added this to our roadmap and we're working on getting it approved and added!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants