Skip to content

Remove giropay. #10989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Remove giropay. #10989

wants to merge 1 commit into from

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented Jun 24, 2025 •
edited
Loading

Summary

Giropay has been deprecated at Stripe, so we're removing it from the SDK.

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-3700

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025 •
edited
Loading

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   4.4 MiB │   4.4 MiB │   +373 B │   9.7 MiB │   9.7 MiB │   -784 B 
     arsc │   2.5 MiB │   2.5 MiB │   -868 B │   2.5 MiB │   2.5 MiB │   -868 B 
 manifest │   5.7 KiB │   5.7 KiB │      0 B │  29.4 KiB │  29.4 KiB │      0 B 
      res │   918 KiB │ 916.8 KiB │ -1.2 KiB │   1.5 MiB │   1.5 MiB │ -2.6 KiB 
   native │   3.5 MiB │   3.5 MiB │      0 B │   8.5 MiB │   8.5 MiB │      0 B 
    asset │   1.6 MiB │   1.6 MiB │ -1.4 KiB │   1.6 MiB │   1.6 MiB │ -1.4 KiB 
    other │ 197.6 KiB │ 197.5 KiB │    -81 B │ 373.3 KiB │ 372.7 KiB │   -696 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  13.1 MiB │  13.1 MiB │ -3.2 KiB │  24.1 MiB │  24.1 MiB │ -6.3 KiB 

         │         raw          │           unique           
         ├───────┬───────┬──────┼───────┬───────┬────────────
 DEX     │ old   │ new   │ diff │ old   │ new   │ diff       
─────────┼───────┼───────┼──────┼───────┼───────┼────────────
   files │     2 │     2 │    0 │       │       │            
 strings │ 47226 │ 47219 │   -7 │ 46035 │ 46032 │ -3 (+1 -4) 
   types │ 16802 │ 16799 │   -3 │ 16208 │ 16207 │ -1 (+0 -1) 
 classes │ 13677 │ 13676 │   -1 │ 13677 │ 13676 │ -1 (+0 -1) 
 methods │ 67628 │ 67620 │   -8 │ 66773 │ 66767 │ -6 (+0 -6) 
  fields │ 44899 │ 44890 │   -9 │ 44601 │ 44597 │ -4 (+4 -8) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  242 │  242 │  0         
 entries │ 6323 │ 6321 │ -2 (+0 -2)
APK 
     compressed      │     uncompressed     │                                
──────────┬──────────┼───────────┬──────────┤                                
 size     │ diff     │ size      │ diff     │ path                           
──────────┼──────────┼───────────┼──────────┼────────────────────────────────
    7 KiB │ -1.4 KiB │   6.9 KiB │ -1.4 KiB │ ∆ assets/dexopt/baseline.prof  
          │ -1.2 KiB │           │ -2.6 KiB │ - res/i1.xml                   
  4.3 MiB │ +1.1 KiB │   9.5 MiB │ +1.2 KiB │ ∆ classes.dex                  
  2.5 MiB │   -868 B │   2.5 MiB │   -868 B │ ∆ resources.arsc               
 89.8 KiB │   -709 B │ 204.4 KiB │   -2 KiB │ ∆ classes2.dex                 
 54.7 KiB │    -38 B │ 121.4 KiB │    -82 B │ ∆ META-INF/CERT.SF             
 51.2 KiB │    -27 B │ 121.3 KiB │    -82 B │ ∆ META-INF/MANIFEST.MF         
  3.6 KiB │    -15 B │  28.9 KiB │   -532 B │ ∆ lpms.json                    
  1.1 KiB │     +1 B │     958 B │     +1 B │ ∆ assets/dexopt/baseline.profm 
    905 B │     -1 B │   2.4 KiB │      0 B │ ∆ res/YB.xml                   
  1.2 KiB │     -1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA            
──────────┼──────────┼───────────┼──────────┼────────────────────────────────
    7 MiB │ -3.2 KiB │  12.5 MiB │ -6.3 KiB │ (total)
DEX 
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   46035 │ 46032 │ -3 (+1 -4) 
  
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"50700e8","r8-mode":"full","version":"8.8.34"}
  
  - Giropay
  - LY6/P;
  - giropay
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"30e0955","r8-mode":"full","version":"8.8.34"}
  

TYPES:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   16208 │ 16207 │ -1 (+0 -1) 
  
  - LY6/P;
  

METHODS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   66773 │ 66767 │ -6 (+0 -6) 
  
  - Y6.P <clinit>()
  - Y6.P a() → H1
  - Y6.P b(boolean) → Set
  - Y6.P c(p) → boolean
  - Y6.P d() → boolean
  - Y6.P e() → F
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   44601 │ 44597 │ -4 (+4 -8) 
  
  + Y6.G c: boolean
  + Y6.M c: boolean
  + c7.H1 c0: H1[]
  + c7.H1 d0: a
  
  - Y6.H c: boolean
  - Y6.N c: boolean
  - Y6.P a: P
  - Y6.P b: H1
  - Y6.b E: b
  - c7.H1 c0: H1
  - c7.H1 d0: H1[]
  - c7.H1 e0: a
ARSC 
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6323 │ 6321 │ -2 (+0 -2) 
  - drawable/stripe_ic_paymentsheet_pm_giropay
  - string/stripe_paymentsheet_payment_method_giropay

@cttsai-stripe
Copy link
Contributor

Should we also remove stripe_ic_paymentsheet_pm_giropay.xml?

@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/remove-giropay branch from dacd4b6 to e0213b5 Compare June 25, 2025 17:31
@jaynewstrom-stripe
Copy link
Collaborator Author

Good catch! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cttsai-stripe cttsai-stripe cttsai-stripe approved these changes

Assignees
No one assigned
Labels
v25
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaynewstrom-stripe @cttsai-stripe