Skip to content

Remove deprecated google pay api #10994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Remove deprecated google pay api #10994

wants to merge 6 commits into from

Conversation

cttsai-stripe
Copy link
Contributor

@cttsai-stripe cttsai-stripe commented Jun 24, 2025 •
edited
Loading

Summary

Remove GooglePayPaymentMethodLauncherContract.kt, GooglePayLauncher.rememberLauncher(), GooglePayPaymentMethodLauncher.rememberLauncher() and GooglePayPaymentMethodLauncher.present() where amount is Int

Motivation

MOBILESDK-3696

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025 •
edited
Loading

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   4.4 MiB │   4.4 MiB │ -1.7 KiB │   9.7 MiB │   9.7 MiB │ -3.2 KiB 
     arsc │   2.5 MiB │   2.5 MiB │      0 B │   2.5 MiB │   2.5 MiB │      0 B 
 manifest │   5.6 KiB │   5.6 KiB │      0 B │  29.1 KiB │  29.1 KiB │      0 B 
      res │   918 KiB │   918 KiB │      0 B │   1.5 MiB │   1.5 MiB │      0 B 
   native │   3.5 MiB │   3.5 MiB │      0 B │   8.5 MiB │   8.5 MiB │      0 B 
    asset │   1.6 MiB │   1.6 MiB │ +1.5 KiB │   1.6 MiB │   1.6 MiB │ +1.5 KiB 
    other │ 197.6 KiB │ 197.6 KiB │     +7 B │ 373.3 KiB │ 373.3 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  13.1 MiB │  13.1 MiB │   -250 B │  24.1 MiB │  24.1 MiB │ -1.8 KiB 

         │         raw          │            unique             
         ├───────┬───────┬──────┼───────┬───────┬───────────────
 DEX     │ old   │ new   │ diff │ old   │ new   │ diff          
─────────┼───────┼───────┼──────┼───────┼───────┼───────────────
   files │     2 │     2 │    0 │       │       │               
 strings │ 47288 │ 47263 │  -25 │ 45984 │ 45977 │  -7 (+1 -8)   
   types │ 16871 │ 16852 │  -19 │ 16179 │ 16174 │  -5 (+0 -5)   
 classes │ 13649 │ 13646 │   -3 │ 13649 │ 13646 │  -3 (+0 -3)   
 methods │ 67508 │ 67473 │  -35 │ 66682 │ 66665 │ -17 (+10 -27) 
  fields │ 44852 │ 44831 │  -21 │ 44468 │ 44456 │ -12 (+21 -33) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6323 │ 6323 │  0
APK 
     compressed      │     uncompressed     │                                           
──────────┬──────────┼───────────┬──────────┤                                           
 size     │ diff     │ size      │ diff     │ path                                      
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
 85.3 KiB │ -2.2 KiB │ 193.1 KiB │ -4.6 KiB │ ∆ classes2.dex                            
  8.5 KiB │ +1.5 KiB │   8.4 KiB │ +1.5 KiB │ ∆ assets/dexopt/baseline.prof             
  4.3 MiB │   +529 B │   9.5 MiB │ +1.3 KiB │ ∆ classes.dex                             
 54.7 KiB │     +5 B │ 121.4 KiB │      0 B │ ∆ META-INF/CERT.SF                        
 51.3 KiB │     +5 B │ 121.4 KiB │      0 B │ ∆ META-INF/MANIFEST.MF                    
  1.2 KiB │     -2 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA                       
    271 B │     -1 B │     120 B │      0 B │ ∆ META-INF/version-control-info.textproto 
    1 KiB │     +1 B │     936 B │     +1 B │ ∆ assets/dexopt/baseline.profm            
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  4.5 MiB │   -250 B │   9.9 MiB │ -1.8 KiB │ (total)
DEX 
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   45984 │ 45977 │ -7 (+1 -8) 
  
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"3d694ea","r8-mode":"full","version":"8.8.34"}
  
  - , injectionParams=
  - InjectionParams(injectorKey=
  - Lcom/stripe/android/googlepaylauncher/GooglePayPaymentMethodLauncherContract;
  - Ly6/X;
  - Ly6/Y;
  - [Ly6/U;
  - [Ly6/V;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"f0d5b67","r8-mode":"full","version":"8.8.34"}
  

TYPES:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   16179 │ 16174 │ -5 (+0 -5) 
  
  - Lcom/stripe/android/googlepaylauncher/GooglePayPaymentMethodLauncherContract;
  - Ly6/X;
  - Ly6/Y;
  - [Ly6/U;
  - [Ly6/V;
  

METHODS:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   66682 │ 66665 │ -17 (+10 -27) 
  
  + C7.i <init>(T)
  + com.stripe.android.googlepaylauncher.GooglePayPaymentMethodLauncherActivity k() → W
  + y6.T <init>(H, String, long, String, String, a)
  + y6.U <init>(W, ContinuationImpl)
  + y6.U o(Object) → Object
  + y6.V <init>(W, ContinuationImpl)
  + y6.V o(Object) → Object
  + y6.W <init>(m, k, T, U, k, e, f0)
  + y6.W a(i, ContinuationImpl) → Object
  + y6.W b(ContinuationImpl) → Object
  
  - C7.i <init>(V)
  - com.stripe.android.googlepaylauncher.GooglePayPaymentMethodLauncherActivity k() → Y
  - com.stripe.android.googlepaylauncher.GooglePayPaymentMethodLauncherContract <init>()
  - com.stripe.android.googlepaylauncher.GooglePayPaymentMethodLauncherContract a(Context, Object) → Intent
  - com.stripe.android.googlepaylauncher.GooglePayPaymentMethodLauncherContract c(Intent, int) → Object
  - y6.T <init>(String, LinkedHashSet, boolean, String, String)
  - y6.U <clinit>()
  - y6.U <init>(H, String, int, String, T)
  - y6.U describeContents() → int
  - y6.U equals(Object) → boolean
  - y6.U hashCode() → int
  - y6.U toString() → String
  - y6.U writeToParcel(Parcel, int)
  - y6.V <clinit>()
  - y6.V <init>(H, String, long, String, String, a)
  - y6.V describeContents() → int
  - y6.V equals(Object) → boolean
  - y6.V hashCode() → int
  - y6.V toString() → String
  - y6.V writeToParcel(Parcel, int)
  - y6.W <init>(Y, ContinuationImpl)
  - y6.W o(Object) → Object
  - y6.X <init>(Y, ContinuationImpl)
  - y6.X o(Object) → Object
  - y6.Y <init>(m, k, V, U, k, e, f0)
  - y6.Y a(i, ContinuationImpl) → Object
  - y6.Y b(ContinuationImpl) → Object
  

FIELDS:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   44468 │ 44456 │ -12 (+21 -33) 
  
  + com.stripe.android.googlepaylauncher.GooglePayPaymentMethodLauncherActivity l: T
  + y6.T j: H
  + y6.T k: String
  + y6.T l: long
  + y6.T o: a
  + y6.U m: Object
  + y6.U n: W
  + y6.U o: int
  + y6.V m: W
  + y6.V n: Object
  + y6.V o: W
  + y6.V p: int
  + y6.W j: m
  + y6.W k: k
  + y6.W l: T
  + y6.W m: U
  + y6.W n: k
  + y6.W o: e
  + y6.W p: f0
  + y6.W q: k0
  + y6.W r: Q
  
  - com.stripe.android.googlepaylauncher.GooglePayPaymentMethodLauncherActivity l: V
  - y6.T j: String
  - y6.T k: LinkedHashSet
  - y6.T l: boolean
  - y6.U CREATOR: Parcelable_Creator
  - y6.U j: H
  - y6.U k: String
  - y6.U l: int
  - y6.U m: String
  - y6.U n: T
  - y6.V CREATOR: Parcelable_Creator
  - y6.V j: H
  - y6.V k: String
  - y6.V l: long
  - y6.V m: String
  - y6.V n: String
  - y6.V o: a
  - y6.W m: Object
  - y6.W n: Y
  - y6.W o: int
  - y6.X m: Y
  - y6.X n: Object
  - y6.X o: Y
  - y6.X p: int
  - y6.Y j: m
  - y6.Y k: k
  - y6.Y l: V
  - y6.Y m: U
  - y6.Y n: k
  - y6.Y o: e
  - y6.Y p: f0
  - y6.Y q: k0
  - y6.Y r: Q

@cttsai-stripe cttsai-stripe force-pushed the cttsai/remove-deprecated-google-pay-api branch from daa046a to 949e228 Compare June 24, 2025 19:34
@cttsai-stripe cttsai-stripe marked this pull request as ready for review June 24, 2025 21:12
@cttsai-stripe cttsai-stripe requested review from a team as code owners June 24, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaynewstrom-stripe jaynewstrom-stripe jaynewstrom-stripe approved these changes

Assignees
No one assigned
Labels
DO-NOT-MERGE v25
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cttsai-stripe @jaynewstrom-stripe