Skip to content

Link Shipping Address Collection #10999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

Link Shipping Address Collection #10999

wants to merge 18 commits into from

Conversation

tillh-stripe
Copy link
Collaborator

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025 •
edited
Loading

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │           uncompressed           
          ├──────────┬──────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old      │ new      │ diff     │ old       │ new       │ diff     
──────────┼──────────┼──────────┼──────────┼───────────┼───────────┼──────────
      dex │  4.4 MiB │  4.4 MiB │ +4.3 KiB │   9.8 MiB │   9.8 MiB │ +6.2 KiB 
     arsc │  2.5 MiB │  2.5 MiB │      0 B │   2.5 MiB │   2.5 MiB │      0 B 
 manifest │  5.7 KiB │  5.7 KiB │      0 B │  29.4 KiB │  29.4 KiB │      0 B 
      res │  918 KiB │  918 KiB │      0 B │   1.5 MiB │   1.5 MiB │      0 B 
   native │  3.5 MiB │  3.5 MiB │      0 B │   8.5 MiB │   8.5 MiB │      0 B 
    asset │  1.6 MiB │  1.6 MiB │    +29 B │   1.6 MiB │   1.6 MiB │    +28 B 
    other │  198 KiB │  198 KiB │     -8 B │ 373.9 KiB │ 373.9 KiB │      0 B 
──────────┼──────────┼──────────┼──────────┼───────────┼───────────┼──────────
    total │ 13.1 MiB │ 13.1 MiB │ +4.3 KiB │  24.2 MiB │  24.2 MiB │ +6.2 KiB 

         │         raw          │             unique              
         ├───────┬───────┬──────┼───────┬───────┬─────────────────
 DEX     │ old   │ new   │ diff │ old   │ new   │ diff            
─────────┼───────┼───────┼──────┼───────┼───────┼─────────────────
   files │     2 │     2 │    0 │       │       │                 
 strings │ 47815 │ 47838 │  +23 │ 46530 │ 46547 │ +17 (+36 -19)   
   types │ 16959 │ 16967 │   +8 │ 16324 │ 16328 │  +4 (+13 -9)    
 classes │ 13775 │ 13779 │   +4 │ 13775 │ 13779 │  +4 (+10 -6)    
 methods │ 68081 │ 68093 │  +12 │ 67185 │ 67194 │  +9 (+587 -578) 
  fields │ 45064 │ 45108 │  +44 │ 44765 │ 44803 │ +38 (+837 -799) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6323 │ 6323 │  0
APK 
      compressed      │     uncompressed     │                                           
───────────┬──────────┼───────────┬──────────┤                                           
 size      │ diff     │ size      │ diff     │ path                                      
───────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
   4.3 MiB │ +3.7 KiB │   9.5 MiB │ +4.1 KiB │ ∆ classes.dex                             
 113.1 KiB │   +572 B │ 259.1 KiB │ +2.1 KiB │ ∆ classes2.dex                            
   8.6 KiB │    +33 B │   8.5 KiB │    +33 B │ ∆ assets/dexopt/baseline.prof             
   1.1 KiB │     -5 B │     972 B │     -5 B │ ∆ assets/dexopt/baseline.profm            
  54.8 KiB │     -5 B │ 121.7 KiB │      0 B │ ∆ META-INF/CERT.SF                        
  51.4 KiB │     -5 B │ 121.7 KiB │      0 B │ ∆ META-INF/MANIFEST.MF                    
     272 B │     +1 B │     120 B │      0 B │ ∆ META-INF/version-control-info.textproto 
     241 B │     +1 B │     101 B │      0 B │ ∆ assets/sentry-debug-meta.properties     
   1.2 KiB │     +1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA                       
───────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
   4.5 MiB │ +4.3 KiB │    10 MiB │ +6.2 KiB │ (total)
DEX 
STRINGS:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   46530 │ 46547 │ +17 (+36 -19) 
  
  + , selectedShippingAddress=
  + , shippingAddresses=
  + , shippingAddressesExpanded=
  + , showShippingAddressSection=false, shippingAddresses=
  + ConsumerState(paymentDetails=
  + LD6/P;
  + LLLLZLLLLLLLLZI
  + LM7/X;
  + LU6/V;
  + LU6/W;
  + LU6/X;
  + LZ5/n;
  + LZ7/S0;
  + Ls8/C;
  + Lw7/a0;
  + Lz6/h;
  + Shipping Address in Link
  + VLLFZLLLLLLLLLZLII
  + VLLFZLLLLLLLLLZLLII
  + VLLLLLLLLLLLLLLLLLLII
  + VLLLLLLLLLLLLLLLLLLLII
  + VLLLLZZLLLZLLLLLLLLZ
  + VLZLLLLLLLLLLLLII
  + VLZLLLLLLLLLLLLLII
  + VLZLLLLLLLLLLLLLLI
  + VLZLLLLLLLLLLLLLLLI
  + [LZ7/R0;
  + [Lt5/G;
  + [Lt5/J;
  + launchAddressElement
  + onAddressSelected
  + onAddressSelected(Lcom/stripe/android/model/ConsumerShippingAddress;)V
  + onShippingAddressesExpandedChanged
  + onShippingAddressesExpandedChanged(Z)V
  + shippingAddresses
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"aa364b9","r8-mode":"full","version":"8.8.34"}
  
  - LLLLZLLLLLLI
  - LV5/s;
  - La5/k;
  - La6/t;
  - Lt5/t1;
  - Lw9/r;
  - Lz9/p;
  - VLLFZLLLLLI
  - VLLFZLLLLLLI
  - VLLLLLLLLLLLLLLLII
  - VLLLLZZLLLZLLLLLL
  - VLZLLLLLLLLLII
  - VLZLLLLLLLLLLII
  - VLZLLLLLLLLLLLI
  - VLZLLLLLLLLLLLLI
  - [LZ7/P0;
  - [Lt5/E;
  - [Lt5/I;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"034ca5f","r8-mode":"full","version":"8.8.34"}
  

TYPES:

   old   │ new   │ diff        
  ───────┼───────┼─────────────
   16324 │ 16328 │ +4 (+13 -9) 
  
  + LD6/P;
  + LM7/X;
  + LU6/V;
  + LU6/W;
  + LU6/X;
  + LZ5/n;
  + LZ7/S0;
  + Ls8/C;
  + Lw7/a0;
  + Lz6/h;
  + [LZ7/R0;
  + [Lt5/G;
  + [Lt5/J;
  
  - LV5/s;
  - La5/k;
  - La6/t;
  - Lt5/t1;
  - Lw9/r;
  - Lz9/p;
  - [LZ7/P0;
  - [Lt5/E;
  - [Lt5/I;
  

METHODS:

   old   │ new   │ diff           
  ───────┼───────┼────────────────
   67185 │ 67194 │ +9 (+587 -578) 
  
  + A8.m1 <init>(String, boolean, Function1, v, Set, List, N, p, int)
  + A8.r1 <init>(v, Function1, Continuation)
  + C6.B <init>(a, N, b, G, F, e, E, b, g0, boolean, k, J)
  + C6.O <init>(c, String, LinkActivityContract, P)
  + D6.A <init>(E, ContinuationImpl)
  + D6.B <init>(E, ContinuationImpl)
  + D6.C <init>(E, ContinuationImpl)
  + D6.D <init>(E, ContinuationImpl)
  + D6.D q(Object) → Object
  + D6.E <init>(a, G, d, f, String)
  + D6.E a(String, J0, boolean, ContinuationImpl) → Object
  + D6.E b(String, J0, boolean, ContinuationImpl) → Object
  + D6.E c(String, String, String, String, G, ContinuationImpl) → Object
  + D6.E d(String, Throwable)
  + D6.E e(String, String, String, String, G, ContinuationImpl) → Object
  + D6.E f(Object) → N
  + D6.F <init>(g0)
  + D6.F a(c)
  + D6.H q(Object) → Object
  + D6.K <init>(Throwable)
  + D6.L <clinit>()
  + D6.M <init>(b)
  + D6.M equals(Object) → boolean
  + D6.M hashCode() → int
  + D6.M toString() → String
  + D6.O <init>(Context, int)
  + D6.O b() → Object
  + D6.P <init>(Context)
  + D6.P a()
  + D6.b <init>(List, List)
  + D6.b equals(Object) → boolean
  + D6.b hashCode() → int
  + D6.b toString() → String
  + D6.c <init>(y, ContinuationImpl)
  + D6.d <init>(y, ContinuationImpl)
  + D6.e <init>(y, ContinuationImpl)
  + D6.f <init>(y, ContinuationImpl)
  + D6.g <init>(y, ContinuationImpl)
  + D6.h <init>(y, ContinuationImpl)
  + D6.i <init>(y, ContinuationImpl)
  + D6.j <init>(y, ContinuationImpl)
  + D6.k <init>(y, ContinuationImpl)
  + D6.l <init>(y, ContinuationImpl)
  + D6.m <init>(y, ContinuationImpl)
  + D6.n <init>(y, b, Continuation)
  + D6.n g(Object, Object) → Object
  + D6.n m(Object, Continuation) → Continuation
  + D6.o <init>(y, ContinuationImpl)
  + D6.p <init>(y, Continuation)
  + D6.p g(Object, Object) → Object
  + D6.p m(Object, Continuation) → Continuation
  + D6.q <init>(y, ContinuationImpl)
  + D6.r <init>(y, ContinuationImpl)
  + D6.s <init>(y, ContinuationImpl)
  + D6.t <init>(y, ContinuationImpl)
  + D6.u <init>(x, Continuation)
  + D6.u q(Object) → Object
  + D6.v <init>(int, Object, Object)
  + D6.v b(h, Continuation) → Object
  + D6.w <init>(y, ContinuationImpl)
  + D6.x <init>(y, ContinuationImpl)
  + D6.x q(Object) → Object
  + D6.y <init>(F, E, y, c, f)
  + D6.y a(String, ContinuationImpl) → Object
  + D6.y b(f2, ContinuationImpl) → Object
  + D6.y c(String, ContinuationImpl) → Object
  + D6.y d(b, boolean, ContinuationImpl) → Enum
  + D6.y e(G) → U
  + D6.y f(Set, Con
...✂

@tillh-stripe tillh-stripe force-pushed the tillh/link-shipping-address branch from bab7df0 to a3065f7 Compare June 25, 2025 14:13
@tillh-stripe tillh-stripe force-pushed the tillh/link-shipping-address branch from a3065f7 to fb94c4c Compare June 25, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tillh-stripe