Skip to content

Remove PaymentSheet.Configuration public constructor #11041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove PaymentSheet.Configuration public constructor #11041

wants to merge 1 commit into from
+70 −205

Conversation

cttsai-stripe
Copy link
Contributor

@cttsai-stripe cttsai-stripe commented Jun 30, 2025 •
edited
Loading

Summary

  1. Removed public constructor
  2. Moved comments from internal constructor to Builder

Merchants should use Builder pattern instead. We'll provide a script assisting migration

Motivation

#10970

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 30, 2025 •
edited
Loading

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.9 KiB │ 302.9 KiB │  0 B │   457 KiB │   457 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.7 KiB │   7.7 KiB │  0 B │   7.4 KiB │   7.4 KiB │  0 B 
    other │  95.8 KiB │  95.8 KiB │  0 B │ 183.5 KiB │ 183.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.8 MiB │   9.8 MiB │  0 B │  21.8 MiB │  21.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20682 │ 20682 │ 0 (+0 -0) 
   types │  6503 │  6503 │ 0 (+0 -0) 
 classes │  5266 │  5266 │ 0 (+0 -0) 
 methods │ 31511 │ 31511 │ 0 (+0 -0) 
  fields │ 18239 │ 18239 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3646 │ 3646 │  0
APK 
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
    272 B │ +2 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 29.2 KiB │ -2 B │  64.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │ -1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
 25.9 KiB │ +1 B │  64.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 56.5 KiB │  0 B │ 130.5 KiB │  0 B │ (total)

@cttsai-stripe cttsai-stripe force-pushed the cttsai/make-ps-configuration-constructor-internal branch 3 times, most recently from 3f746a2 to 5edfe9c Compare June 30, 2025 18:19
@cttsai-stripe cttsai-stripe marked this pull request as ready for review June 30, 2025 18:54
@cttsai-stripe cttsai-stripe requested review from a team as code owners June 30, 2025 18:54
jaynewstrom-stripe
jaynewstrom-stripe reviewed Jun 30, 2025
View reviewed changes
...va/com/stripe/android/financialconnections/example/FinancialConnectionsPlaygroundActivity.kt Outdated
email = email.takeIf { it.isNotBlank() },
),
)
val config = PaymentSheet.Configuration.Builder(merchantDisplayName = "Example, Inc.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you separate these changes, and merge them before the major version cut?

@cttsai-stripe cttsai-stripe mentioned this pull request Jun 30, 2025
Merged
3 tasks
@cttsai-stripe cttsai-stripe force-pushed the cttsai/make-ps-configuration-constructor-internal branch from 5edfe9c to 62bd820 Compare June 30, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaynewstrom-stripe jaynewstrom-stripe jaynewstrom-stripe approved these changes

Assignees
No one assigned
Labels
DO-NOT-MERGE v25
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cttsai-stripe @jaynewstrom-stripe