fix: enable types in JS code blocks #1398
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eltigerchino
commented
Jun 27, 2025
| @@ -7,11 +7,7 @@ export const render_content = ( | |||
| ) => { | |||
| return render_content_markdown(filename, body, options, (filename, source) => { | |||
| // TODO these are copied from Svelte and SvelteKit - adjust for new filenames | |||
| const injected = []; | |||
|
|
|||
| if (/(svelte)/.test(source) || filename.includes('typescript')) { | |||
There was a problem hiding this comment.
This was previously always being injected for any file that mentions 'svelte'. Instead, we can just reference the Svelte types in the Twoslash typescript options
eltigerchino
commented
Jun 27, 2025
| if ( | ||
| source.includes('$app/') || | ||
| source.includes('$service-worker') || | ||
| source.includes('@sveltejs/kit/') |
There was a problem hiding this comment.
We don't need to check for @sveltejs/kit/* because Twoslash can resolve those itself
eltigerchino
commented
Jun 27, 2025
| @@ -71,10 +69,6 @@ export const render_content = ( | |||
| injected.push('// @errors: 7006 7031'); | |||
| } | |||
|
|
|||
| if (filename.endsWith('10-configuration.md')) { | |||
There was a problem hiding this comment.
There is no such file in the docs
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #999
This PR makes the following changes to fix types in the docs:
This PR shouldn't be merged until all the required docs have their TypeScript error markers updated.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.