[Process] Deprecate using values that are not string for Process::setStdin and ProcessBuilder::setInput #10930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| if (null !== $input && !is_string($input)) { | ||
| if (is_scalar($input) || (is_object($input) && method_exists($input, '__toString'))) { | ||
| trigger_error(sprintf('% only accepts stream resource and string as input.'), E_USER_DEPRECATED); |
There was a problem hiding this comment.
and I would not forbid passing another scalar but just cast it when setting it. PHP does not have strict types for scalars
|
PR rebased and updated, comments addressed. |
| @@ -971,3 +971,4 @@ UPGRADE FROM 2.x to 3.0 | |||
|
|
|||
| * Process::setStdin() and Process::getStdin() have been removed. Use | |||
| Process::setInput() and Process::getInput() that works the same way. | |||
| * Process::setInput and ProcessBuilder::setInput do not accept non-scalar types. | |||
There was a problem hiding this comment.
missing () at the end of the method name (same below).
|
PR Updated, comments addressed |
| @@ -87,7 +87,12 @@ public static function escapeArgument($argument) | |||
| public static function validateInput($caller, $input) | |||
| { | |||
| if (null !== $input) { | |||
| if (is_scalar($input) || (is_object($input) && method_exists($input, '__toString'))) { | |||
| if (is_object($input) && method_exists($input, '__toString')) { | |||
| trigger_error(sprintf('% only accepts string as input.', $caller), E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
we don't trigger deprecation errors for stuff working until 3.0. We will only do it the last minor release before 3.0
…Stdin and ProcessBuilder::setInput
|
PR updated, @stof comments addressed |
fabpot
added a commit
that referenced
this pull request
May 23, 2014
…or Process::setStdin and ProcessBuilder::setInput (romainneutron) This PR was merged into the 2.4-dev branch. Discussion ---------- [Process] Deprecate using values that are not string for Process::setStdin and ProcessBuilder::setInput | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | n/a | License | MIT This deprecates passing a `Process` input any value that is not a strict string. This needs #10929 to be merged. I don't know if the use of `trigger_error` is correct or should be removed. Commits ------- 9887b83 [Process] Deprecate using values that are not string for Process::setStdin and ProcessBuilder::setInput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates passing a
Processinput any value that is not a strict string. This needs #10929 to be merged.I don't know if the use of
trigger_erroris correct or should be removed.