[2.5][PropertyAccess] Fixed getValue() when accessing non-existing indices of ArrayAccess implementations #10946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw new NoSuchIndexException(sprintf( | ||
| 'Cannot read property "%s". Available properties are "%s"', | ||
| $property, | ||
| print_r(array_keys($objectOrArray), true) |
There was a problem hiding this comment.
you sould keep it on 1 line, like previously
There was a problem hiding this comment.
@webmozart why use print_r? It prints way more than the available keys.
|
shoudln't this one be closed in favor of #10947 ? |
|
@stof No, one of the PRs is for 2.4, the other for master. Applying the 2.4 version to master is non-trivial, which is why I created separate PRs. |
fabpot
added a commit
that referenced
this pull request
May 21, 2014
…existing indices of ArrayAccess implementations (webmozart) This PR was merged into the 2.4 branch. Discussion ---------- [2.4][PropertyAccess] Fixed getValue() when accessing non-existing indices of ArrayAccess implementations | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR backports two test refactoring commits from the master branch. The third commit is basically the same as #10946. Commits ------- 5b5a6b6 [PropertyAccess] Fixed getValue() when accessing non-existing indices of ArrayAccess implementations 91ee821 [PropertyAccess] Refactored PropertyAccessorCollectionTest 5614303 [PropertyAccess] Refactored PropertyAccessorTest
… of ArrayAccess implementations
|
Updated, removed the "return null" statement. |
fabpot
added a commit
that referenced
this pull request
May 21, 2014
…existing indices of ArrayAccess implementations (webmozart) This PR was merged into the 2.5-dev branch. Discussion ---------- [2.5][PropertyAccess] Fixed getValue() when accessing non-existing indices of ArrayAccess implementations | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Previously, when the following code was executed: ```php $object = new ImplOfArrayAccess(); $propertyAccessor->setValue($object, '[index]', 'Value'); ``` and that index did not exist, a fatal error would be generated because `array_keys()` was executed on `$object`. This error is fixed now. Commits ------- fef698e [PropertyAccess] Fixed getValue() when accessing non-existing indices of ArrayAccess implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the following code was executed:
and that index did not exist, a fatal error would be generated because
array_keys()was executed on$object. This error is fixed now.