Skip to content

[Debug] throw even in stacking mode to preserve code paths #10989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2014

Conversation

nicolas-grekas
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no if throwing a parent class is accepted
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR none

Throwing \ErrorException instead of ContextErrorException is a better work around for https://bugs.php.net/42098

@fabpot fabpot merged commit d06b206 into symfony:2.5 May 25, 2014
fabpot added a commit that referenced this pull request May 25, 2014
… (nicolas-grekas)

This PR was merged into the 2.5 branch.

Discussion
----------

[Debug] throw even in stacking mode to preserve code paths

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no if throwing a parent class is accepted
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | none

Throwing \ErrorException instead of ContextErrorException is a better work around for https://bugs.php.net/42098

Commits
-------

d06b206 [Debug] throw even in stacking mode to preserve code paths
@nicolas-grekas nicolas-grekas deleted the throw-e-strict branch May 25, 2014 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants