[Security] Add missing dot at the end of an exception message #11215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rybakit
commented
Jun 24, 2014
rybakit
commented
| Q | A |
|---|---|
| Fixed tickets | - |
| License | MIT |
|
I'm not sure about it. the message is not a sentence anyway. |
|
What about this message ( ) then? And would it make sense to maybe replace "Bad credentials" with "Invalid credentials."? |
|
We do have dots on all error messages, so I think it makes sense. 👍 |
|
Thank you @rybakit. |
fabpot
added a commit
that referenced
this pull request
Jul 25, 2014
…ssage (rybakit) This PR was merged into the 2.6-dev branch. Discussion ---------- [Security] Add missing dot at the end of an exception message | Q | A | ------------- | --- | Fixed tickets | - | License | MIT Commits ------- 8e1f978 Add missing dot at the end of an exception message
|
IMHO, the dots at exceptions could be omitted to allow imbricated handling of exceptions. For example, when rendering a message from a catchable exception. |
phansys
added a commit
to phansys/FOSUserBundle
that referenced
this pull request
Aug 4, 2014
… order to track [this update](symfony/symfony#11215).
phansys
added a commit
to phansys/FOSUserBundle
that referenced
this pull request
Aug 4, 2014
… order to track [this update](symfony/symfony#11215).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.