remove the scope from the output of the container:debug command #11317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jul 5, 2014
xabbuh
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #11302 |
| License | MIT |
| Doc PR |
|
I've checked the Symfony documentation and there are no listings for the output of the |
|
@javiereguiluz Thanks for checking the docs. |
|
👍 |
| @@ -323,7 +323,6 @@ private function getContainerDefinitionDocument(Definition $definition, $id = nu | |||
| $serviceXML->setAttribute('factory-method', $definition->getFactoryMethod()); | |||
| } | |||
|
|
|||
| $serviceXML->setAttribute('scope', $definition->getScope()); | |||
There was a problem hiding this comment.
I would not removed the scope from non-text formats (YAML, XML, ...) as they mostly consumed by tools that might need this information.
There was a problem hiding this comment.
Fair point.
What do you think about the output of a single service? Would you like to keep the scope there too as @stof suggested?
|
I updated the pull request to remove the scope information only in the list of services when the text format is used. |
|
👍 |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jul 23, 2014
…g command (xabbuh) This PR was merged into the 2.6-dev branch. Discussion ---------- remove the scope from the output of the container:debug command | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11302 | License | MIT | Doc PR | Commits ------- f56b731 remove the scope from the output of the container:debug command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.