Added support for encoding and decoding namespaced xml (xmlns) #11375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattvick I've rewritten your commit to use the new implementation, I hope its ok for you. |
|
@ClementGautier sure thanks |
|
👍 |
|
|
||
| $xpath = new \DOMXPath($dom); | ||
| $data = array(); | ||
| foreach( $xpath->query('namespace::*', $dom->documentElement) as $nsNode ) { |
There was a problem hiding this comment.
should be foreach ($xpath->query('namespace::*', $dom->documentElement) as $nsNode) {
There was a problem hiding this comment.
@jakzal thanks
|
👍 |
| $data['@'.$nsNode->nodeName] = $nsNode->nodeValue; | ||
| } | ||
|
|
||
| if (isset($data['@xmlns:xml'])) { |
There was a problem hiding this comment.
isset is unnecessary... unset will work without warning if the key is defined or not
|
Thank you @ClementGautier. |
fabpot
added a commit
that referenced
this pull request
Jul 25, 2014
… (xmlns) (mattvick) This PR was merged into the 2.6-dev branch. Discussion ---------- Added support for encoding and decoding namespaced xml (xmlns) Q | A ------------ | ------------- Bug fix? | no New feature? | yes BC breaks? | no Deprecations? | no Tests pass? | yes Fixed tickets | #10625 License | MIT Complete this PR : #9156 Commits ------- 9d6b20c Added support for encoding and decoding namespaced xml (xmlns)
|
This was actually a surprising BC break for us. All these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete this PR : #9156