[Validator] Fixed object initializers in 2.5 version of the Validator #11410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @internal Used by the validator engine. Should not be called by user | ||
| * code. | ||
| * | ||
| * @see \Symfony\Component\Validator\ObjectInitializerInterface |
There was a problem hiding this comment.
you already added a use statement for this
There was a problem hiding this comment.
Removed the use statement.
There was a problem hiding this comment.
We are doing the opposite in Symfony. Use the class name in phpdocs and add a use statement.
webmozart
added a commit
to webmozart/symfony
that referenced
this pull request
Jul 17, 2014
…called only once per object
|
fixes the problem for me! |
|
👍 |
1 similar comment
|
👍 |
webmozart
added a commit
to webmozart/symfony
that referenced
this pull request
Jul 18, 2014
…called only once per object
fabpot
added a commit
that referenced
this pull request
Jul 18, 2014
…are called only once per object (webmozart) This PR was merged into the 2.3 branch. Discussion ---------- [Validator] Backported #11410 to 2.3: Object initializers are called only once per object | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Before, object initializers were called multiple times if an object was validated in different groups in the same validation run. The initializers, however, are not aware of the current validation group, so calling them more than once does not make sense. Now, object initializers are called exactly once per validated object. See #11410 Commits ------- 291cbf9 [Validator] Backported #11410 to 2.3: Object initializers are called only once per object
webmozart
added a commit
to webmozart/symfony
that referenced
this pull request
Jul 21, 2014
…n of the Validator (webmozart) This PR was merged into the 2.5 branch. Discussion ---------- [Validator] Fixed object initializers in 2.5 version of the Validator | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#11159 | License | MIT | Doc PR | - Object initializers were forgot in the 2.5 Validator API. This PR implements them. A bug was fixed also in the old version which resulted in the initializers being called multiple times if an object was validated in multiple groups within the same validation run. This fix will be backported separately to older versions. Commits ------- ce04073 [Validator] Fixed object initializers in 2.5 version of the Validator
webmozart
added a commit
that referenced
this pull request
Jul 21, 2014
…e Validator (webmozart) This PR was merged into the 2.5 branch. Discussion ---------- [Validator] Fixed object initializers in 2.5 version of the Validator | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11159 | License | MIT | Doc PR | - Object initializers were forgot in the 2.5 Validator API. This PR implements them. A bug was fixed also in the old version which resulted in the initializers being called multiple times if an object was validated in multiple groups within the same validation run. This fix will be backported separately to older versions. Commits ------- ce04073 [Validator] Fixed object initializers in 2.5 version of the Validator
fabpot
added a commit
that referenced
this pull request
Jul 24, 2014
* 2.3: [Translator] Use quote to surround invalid locale Optimize assertLocale regexp [Validator] Backported #11410 to 2.3: Object initializers are called only once per object [Translator][FrameworkBundle] Added @ to the list of allowed chars in Translator [Process] Reduce I/O load on Windows platform [Form] Check if IntlDateFormatter constructor returned a valid object before using it
fabpot
added a commit
that referenced
this pull request
Jul 24, 2014
* 2.4: [Translator] Use quote to surround invalid locale Optimize assertLocale regexp [ExpressionLanguage] Fixed an issue with # characters in double quoted string literals Add some tweaks to the pt_BR translations [Validator] Backported #11410 to 2.3: Object initializers are called only once per object [Translator][FrameworkBundle] Added @ to the list of allowed chars in Translator [Process] Reduce I/O load on Windows platform [Form] Check if IntlDateFormatter constructor returned a valid object before using it Conflicts: src/Symfony/Component/Validator/Tests/ValidationVisitorTest.php
fabpot
added a commit
that referenced
this pull request
Jul 24, 2014
* 2.5: [Translator] Use quote to surround invalid locale [Validator] Fixed memory leak in ValidatorBuilder [FrameworkBundle] changed KernelTestCase::getKernelClass() to check $_SERVER['KERNEL_DIR'] before invoking getPhpUnitXmlDir() Optimize assertLocale regexp [ExpressionLanguage] Fixed an issue with # characters in double quoted string literals [Validator] Fixed object initializers in 2.5 version of the Validator Add some tweaks to the pt_BR translations [Validator] Backported #11410 to 2.3: Object initializers are called only once per object [Translator][FrameworkBundle] Added @ to the list of allowed chars in Translator [Process] Reduce I/O load on Windows platform [Form] Check if IntlDateFormatter constructor returned a valid object before using it Conflicts: src/Symfony/Component/Process/ProcessPipes.php
romainneutron
added a commit
that referenced
this pull request
Jul 25, 2014
…romainneutron) This PR was merged into the 2.3 branch. Discussion ---------- fix signal handling in wait() on calls to stop() | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11286 | License | MIT | Doc PR | ``wait()`` throws an exception when the process was terminated by a signal. This should not happen when the termination was requested by calling the ``stop()`` method (for example, inside a callback which is passed to ``wait()``). Commits ------- 5939d34 [Process] Fix unit tests in sigchild environment eb68662 [Process] fix signal handling in wait() 94ffc4f bug #11469 [BrowserKit] Fixed server HTTP_HOST port uri conversion (bcremer, fabpot) 103fd88 [BrowserKit] refactor code and fix unquoted regex f401ab9 Fixed server HTTP_HOST port uri conversion 045cbc5 bug #11425 Fix issue described in #11421 (Ben, ben-rosio) f5bfa9b bug #11423 Pass a Scope instance instead of a scope name when cloning a container in the GrahpvizDumper (jakzal) 3177be5 minor #11464 [Translator] Use quote to surround invalid locale (lyrixx) c9742ef [Translator] Use quote to surround invalid locale 4dbe0e1 bug #11120 [2.3][Process] Reduce I/O load on Windows platform (romainneutron) 797d814 bug #11342 [2.3][Form] Check if IntlDateFormatter constructor returned a valid object before using it (romainneutron) 0b5348e minor #11441 [Translator] Optimize assertLocale regexp (Jérémy Derussé) 537c39b Optimize assertLocale regexp 4cf50e8 Bring code into standard 9f4313c [Process] Add test to verify fix for issue #11421 02eb765 [Process] Fixes issue #11421 6787669 [DependencyInjection] Pass a Scope instance instead of a scope name. 9572918 bug #11411 [Validator] Backported #11410 to 2.3: Object initializers are called only once per object (webmozart) 291cbf9 [Validator] Backported #11410 to 2.3: Object initializers are called only once per object efab884 bug #11403 [Translator][FrameworkBundle] Added @ to the list of allowed chars in Translator (takeit) 3176f8b [Translator][FrameworkBundle] Added @ to the list of allowed chars in Translator 91e32f8 bug #11381 [2.3] [Process] Use correct test for empty string in UnixPipes (whs, romainneutron) 45df2f3 minor #11397 [2.3][Process] Fix unit tests on Windows platform (romainneutron) cec0a45 [Process] Adjust PR #11264, make it Windows compatible and fix CS d418935 [Process] Fix unit tests on Windows platform ff0bb01 [Process] Reduce I/O load on Windows platform ace5a29 bumped Symfony version to 2.3.19 75e07e6 updated VERSION for 2.3.18 4a12f4d update CONTRIBUTORS for 2.3.18 98b891d updated CHANGELOG for 2.3.18 06a80fb Validate locales sets intos translator 06fc97e feature #11367 [HttpFoundation] Fix to prevent magic bytes injection in JSONP responses... (CVE-2014-4671) (Andrew Moore) 3c54659 minor #11387 [2.3] [Validator] Fix UserPassword validator translation (redstar504) 73d50ed Fix UserPassword validator translation 93a970c bug #11386 Remove Spaceless Blocks from Twig Form Templates (chrisguitarguy) 8f9ed3e Remove Spaceless Blocks from Twig Form Templates 9e1ea4a [Process] Use correct test for empty string in UnixPipes 6af3d05 [HttpFoundation] Fix to prevent magic bytes injection in JSONP responses (Prevents CVE-2014-4671) ebf967d [Form] Check if IntlDateFormatter constructor returned a valid object before using it
oleg-andreyev
pushed a commit
to oleg-andreyev/symfony
that referenced
this pull request
Jul 25, 2014
* upstream/master: (1619 commits) fixed CS [Translator] Use quote to surround invalid locale Allow exception bubbling in RememberMeListener [FrameworkBundle] improved controller name parse error message [DomCrawler] Added node name getter [Validator] Fixed memory leak in ValidatorBuilder [FrameworkBundle] changed KernelTestCase::getKernelClass() to check $_SERVER['KERNEL_DIR'] before invoking getPhpUnitXmlDir() [Validator] Improve UserPassword message Optimize assertLocale regexp [ExpressionLanguage] Fixed an issue with # characters in double quoted string literals [Validator] Fixed object initializers in 2.5 version of the Validator [Console] Fix test on windows Add some tweaks to the pt_BR translations [Validator] Backported symfony#11410 to 2.3: Object initializers are called only once per object Rename Specificity->compare() to compareTo() [Translator][FrameworkBundle] Added @ to the list of allowed chars in Translator fixed CS Add compare method to Specificity [Process] Adjust PR symfony#11264, make it Windows compatible and fix CS [Process] Fix unit tests on Windows platform ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object initializers were forgot in the 2.5 Validator API. This PR implements them.
A bug was fixed also in the old version which resulted in the initializers being called multiple times if an object was validated in multiple groups within the same validation run. This fix will be backported separately to older versions.