Extracted the DI loading of an array from the YamlFileLoader #11954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to reuse the logic easily for other loaders needing to extract data from an array.
stof
force-pushed
the
di_array_loader
branch
from
2aad277 to
ec575d3
Compare
|
exactly what i was thinking, this is very good @stof 👍 |
| throw new InvalidArgumentException('The values in the "imports" key should be arrays.'); | ||
| } | ||
|
|
||
| $this->import($import['resource'], null); |
There was a problem hiding this comment.
You should check if the key resource exists
|
I'm 👎 as enabling the YAML conventions in an array loader looks like a non-sense to me. |
|
Yeah, this was the point where I was not sure about this. I agree that the string-based convention to reference services and others are a bit hackish. Closing this, and the PlainArrayLoader should not rely on such convention anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to reuse the logic easily for other loaders needing to extract data from an array.
Note that references and expressions are subject to the same syntax than in YAML files. the goal is to load arrays from a place where you might not be able to instantiate objects.
currently, only the YAMLFileLoader is using it, but the PlainArrayLoader (better named ArrayFileLoader btw) submitted in #11953 could reuse it as well. This would make it benefit from the safeguards added in #11374 as well.
I haven't added dedicated tests yet (but the code is executed by the YamlFileLoader tests). I can add some tests if there is an interest in merging this.