[Form] add back model_timezone and view_timezone options #13241
Conversation
|
I think passing the actual value of |
|
Failures don't seem to be related to this change afaics. |
|
I'd like to merge this one fast to be able to release 2.6.2. Everything's ok? |
|
ping @symfony/deciders |
|
|
||
| $form->setData('2010-06-02'); | ||
|
|
||
| $this->assertEquals('01.06.2010', $form->getViewData()); |
There was a problem hiding this comment.
This particular test shows the two problematic options are pointless and might be misleading in case of Date/Birthday/Time types. It doesn't matter in which timezone a person was born, changing a timezone shouldn't change a date of birth.
There was a problem hiding this comment.
That said it's hard to believe that anyone using these types has relied on date being shifted in certain scenarios. I'd rather treat it as a bug.
I think it's fine to bring the options back and ignore them. We shouldn't suggest in the readme they're supported though.
There was a problem hiding this comment.
Would you then suggest to remove these tests and the entry I made to the changelog here?
|
I'm going to merge this one today to be able to release 2.6.2. Any other feedback before the merge? |
|
Thank you @xabbuh. |
…ns (xabbuh) This PR was merged into the 2.6 branch. Discussion ---------- [Form] add back model_timezone and view_timezone options | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13224 | License | MIT | Doc PR | TODO (deprecate the `model_timezone` and `view_timezone` options) This reverts #12404. Commits ------- 1c4a75a add back model_timezone and view_timezone options
TODO (deprecate themodel_timezoneandview_timezoneoptions)This reverts #12404.