[DependencyInjection] make dumping inlined configurators to XML possible #13557
Conversation
xabbuh
commented
Jan 30, 2015
xabbuh
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
xabbuh
force-pushed
the
inlined-configurators
branch
from
a39c494 to
a9b66ad
Compare
|
If this is considered a new feature, it should be discussed whether or not it can make it into Symfony 2.7. And we could then also think about a similar way for inlining service factories (see #13913). |
|
Looks good to me. Adding something similar for service factories would be event better (can you add this to this PR as well?). We still have time for including this in 2.7, so let's try to make it happen. |
|
Thanks for the feedback. I think I can do something like this for the factories here too until the end of the week. |
|
... last week to make it available in 2.7 :) |
|
@fabpot Can you please merge the |
|
@xabbuh done |
| <container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | ||
| <services> | ||
| <service id="foo" class="Foo"> | ||
| <configurator-service> |
There was a problem hiding this comment.
couldn't it reuse the <configurator> tag instead of using a different one ?
|
As @stof pointed out, the implementation was not completely correct and was also a bit too complicated. Also, these changes need to be based on the |
… services to XML (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [DependencyInjection] make it possible to dump inlined services to XML | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13557 | License | MIT | Doc PR | Commits ------- 504e338 make it possible to dump inlined services to XML
