Adding UPGRADE-2.7 about small BC break in InputDefinition #14782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
added a commit
to weaverryan/Behat
that referenced
this pull request
May 29, 2015
Without this, PHP throws an error. We're not using this argument - and I don't think that's a huge deal, but we are suppressing this error. In Symfony 2.6 and earlier before the parent argument was added, this extra arg won't cause an issue. See symfony/symfony#13220 and symfony/symfony#14782
weaverryan
added a commit
to weaverryan/Behat
that referenced
this pull request
May 29, 2015
Without this, PHP throws an error. We're not using this argument - and I don't think that's a huge deal, but we are suppressing this error. In Symfony 2.6 and earlier before the parent argument was added, this extra arg won't cause an issue. See symfony/symfony#13220 and symfony/symfony#14782
|
👍 |
1 similar comment
|
👍 |
|
Thank you @weaverryan. |
fabpot
added a commit
that referenced
this pull request
May 29, 2015
…on (weaverryan) This PR was merged into the 2.7 branch. Discussion ---------- Adding UPGRADE-2.7 about small BC break in InputDefinition Hi guys! | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13220 | License | MIT | Doc PR | n/a In #13220, a small BC break was introduced when `InputDefinition::getSynopsis()` was given an optional argument. This, for example, breaks Behat 2.5, which overrides this method. I don't think this was noticed before, and it may be too late (or not worth it) to reverse the BC break. So, I've at least doc'ed it. Thanks! Commits ------- a7985d2 Fixing phpdoc typo c35f2c8 Talking about getSynopsis()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
In #13220, a small BC break was introduced when
InputDefinition::getSynopsis()was given an optional argument. This, for example, breaks Behat 2.5, which overrides this method. I don't think this was noticed before, and it may be too late (or not worth it) to reverse the BC break.So, I've at least doc'ed it.
Thanks!