Do not trigger deprecation error in ResolveParameterPlaceHoldersPass #14988
Conversation
murnieza
commented
Jun 15, 2015
murnieza
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | none |
| License | MIT |
| Doc PR | none |
| @@ -38,7 +38,7 @@ public function process(ContainerBuilder $container) | |||
| $definition->setFile($parameterBag->resolveValue($definition->getFile())); | |||
| $definition->setArguments($parameterBag->resolveValue($definition->getArguments())); | |||
| if ($definition->getFactoryClass(false)) { | |||
| $definition->setFactoryClass($parameterBag->resolveValue($definition->getFactoryClass())); | |||
| $definition->setFactoryClass($parameterBag->resolveValue($definition->getFactoryClass(false))); | |||
There was a problem hiding this comment.
I think this is no longer required, see #14900.
There was a problem hiding this comment.
Yes it is! We still have to trigger the relevant notices, and only them. Silencing can be turned off (and will be by users preparing for 3.0 migration).
|
I voted too quickly, removing it for now. When this code path is taken, it means one is using a deprecated service factories configuration. Why should we hide the notice? To me, there is something to upgrade, thus to warn about. Did I miss something? |
|
@nicolas-grekas but you already got the notice in the place using it. This will trigger a second notice in a place out of the control of the user |
|
btw, the call to |
|
@stof true, thanks for the review! 👍 then |
|
Thank you @murnieza. |
…eHoldersPass (murnieza) This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #14988). Discussion ---------- Do not trigger deprecation error in ResolveParameterPlaceHoldersPass | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | none Commits ------- 600078a Do not trigger deprecation error in ResolveParameterPlaceHoldersPass
