[PhpUnitBridge] Enforce @-silencing of deprecation notices according to new policy #15031
Conversation
nicolas-grekas
commented
Jun 18, 2015
nicolas-grekas
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | symfony/symfony-docs#5413 |
nicolas-grekas
force-pushed
the
deprec-strict
branch
from
314eef4 to
9eea9eb
Compare
|
This may be an issue for deprecations triggered in other libraries than Symfony though, if they don't use the new silencing pattern |
|
Yes and no: if the deprecations where in place before the bridge was released, then these libs already have a way to make their users handle them. If the deprecations where added by taking inspiration from Symfony, then this is a recent move and I'd advocate we need to push them one step forward. |
|
Well, pushing to the new way is indeed a good idea. 👍 You should also update http://symfony.com/doc/current/contributing/code/conventions.html#deprecations with the new convention btw |
|
Doc PR is symfony/symfony-docs#5413 |
|
Thank you @nicolas-grekas. |
… according to new policy (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [PhpUnitBridge] Enforce @-silencing of deprecation notices according to new policy | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#5413 Commits ------- 9eea9eb [PhpUnitBridge] Enforce @-silencing of deprecation notices according to new policy
