[Finder] Merge regexps for performance #15828
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
finder-merge-rx
branch
from
41b9f93 to
91019a5
Compare
nicolas-grekas
force-pushed
the
finder-merge-rx
branch
from
91019a5 to
c59f366
Compare
| @@ -61,7 +61,7 @@ class Regex implements ValueInterface | |||
| */ | |||
| public static function create($expr) | |||
| { | |||
| if (preg_match('/^(.{3,}?)([imsxuADU]*)$/', $expr, $m)) { | |||
| if (preg_match('/^(.{2,}?)([imsxuADU]*)$/', $expr, $m)) { | |||
There was a problem hiding this comment.
Empty regexps (//) are valid
|
What do we do with this PR? |
|
Closing as this PR uses the Regex class that does not exist anymore. @stof if you have a better idea, feel free to open a PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #15826. May be superseded by an other PR from @stof, still submitting for history at least.