[translator] Consider numeric messages as same as fallback #16062
Conversation
It does not make sense to warn the user because "2015" or "10" are not translated. Maybe numeric values should not be counted at all | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | -
|
IMO the it should stay, having the translator called for numbers is a problem that should be fixed in the app making the warning useful. |
|
I understand, but in my case, I had many warnings because of the use of the native DateTimeType in a form. |
|
The DateTimeType triggering warnings will be fixed in 2.8 (was fixed by #15301). |
|
My bad. I still consider it's useless to warn about non translated numeric values but you're righ : it's the responsibility of the developer to not call the translator for that. |
|
@gregquat warning is not useless: it is needed to make the developer aware that he is using the translator for such case, adding useless overhead (this is how we detected that DateTimeType was forgotten in 2.7 when adding features to skip the translator in the form component). |
It does not make sense to warn the user because "2015" or "10" are not translated.
Maybe numeric values should not be counted at all