[2.8] [Form] minor fix some regression in tests with placeholder in AbstractLayout #17913
Conversation
HeahDude
commented
Feb 24, 2016
HeahDude
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | - |
|
Tests are actually failing globally in travis on 2.8, this PR is the fix. |
|
Some builds still fail but locally tests are green. Am I missing something ? (sorry for the) ping @nicolas-grekas |
|
👍 |
|
@xabbuh forgive me to ask this as I don't understand, what about the failing builds ? |
|
@HeahDude The failing tests on AppVeyor have been fixed in the meantime (you can trigger a rebuild by push a new commit). The |
|
ping @symfony/deciders Status: Reviewed |
|
Ok thank you @xabbuh, I was just worried because some tests I fixed here were still failing in some travis build (with php 5.6) while the others were green (green also for my local tests and I am on php 5.6). |
|
Thank you @HeahDude. |
…ceholder in AbstractLayout (HeahDude) This PR was merged into the 2.8 branch. Discussion ---------- [2.8] [Form] minor fix some regression in tests with placeholder in AbstractLayout | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | - Commits ------- 6977583 [2.8] [Form] minor fix some tests with placeholder in AbstractLayout
