👍

This should be applied on 2.8 to me.
👍

@nicolas-grekas why in 2.8 only if it was planned to be removed since 2.3?

Should have done this PR a long time ago.

We can't add a deprecation in a patch release, so this should be deprecated in 3.1 and removed in 4.0.

@jvasseur but you have to consider that the corresponding code has already been removed from 3.0. That's why this should go on 2.8 to me: earlier would break the not-in-patch-release constraint, and 2.8 is really the branch were we missed adding the notices while we removed the code on 3.0.

but you have to consider that the corresponding code has already been removed from 3.0.

AFAICS this code is still in 3.0 :/ https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Serializer/Serializer.php#L65

The property is still in 3.0, but not the code that read from it in case someone was filling the cache manually (it was lost in a merge).

The property is still in 3.0, but not the code that read from it in case someone was filling the cache manually (it was lost in a merge).

@jvasseur that's what you removed from #17140 right?

But the issue is that it's still in 3.0 as protected in an extendable class, so it can still be potentially used. As it has never been deprecated clearly, removing it at this point would be a BC break. So maybe I should add "will be removed in 4.0".

That's why this should go on 2.8 to me: earlier would break the not-in-patch-release constraint, and 2.8 is really the branch were we missed adding the notices while we removed the code on 3.0.

@nicolas-grekas I'm not sure to understand why this would break the not-in-patch-release constraint. But as the code is still present in 3.0 should this be added to master or 3.0 instead?

@theofidry in #17140, I removed the code writing into the normalizer cache but not the code reading from it (https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Serializer/Serializer.php#L232-L235) in case someone was manually filling the cache.

My plan was to add the deprecation in 3.1 (next minor release) and remove the property in 4.0

good to me on master

good to me on master

Closing in favour of #18588 then.