[Yaml] Avoid using both Input/Output and SymfonyStyle in LintCommand #19160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
force-pushed
the
patch_yaml_lintcommand
branch
4 times, most recently
from
130fa67 to
5f7ad81
Compare
| { | ||
| $countFiles = count($filesInfo); | ||
| $erroredFiles = 0; | ||
|
|
||
| foreach ($filesInfo as $info) { | ||
| if ($info['valid'] && $output->isVerbose()) { | ||
| if ($info['valid'] && $this->outputCorrectFile) { |
There was a problem hiding this comment.
Should I check output verbosity too for per-file errors?
There was a problem hiding this comment.
No, errors should always be displayed.
Remove input/output from method arguments, use SymfonyStyle instead Avoid 'error in filename' if no filename as argument Add missing array typehint to files argument of display*() methods Store format option as member rather than pass it in method calls CS fixes
chalasr
force-pushed
the
patch_yaml_lintcommand
branch
from
5f7ad81 to
dd84b7f
Compare
| { | ||
| $countFiles = count($filesInfo); | ||
| $erroredFiles = 0; | ||
|
|
||
| foreach ($filesInfo as $info) { | ||
| if ($info['valid'] && $output->isVerbose()) { | ||
| if ($info['valid'] && $this->displayCorrectFiles) { |
There was a problem hiding this comment.
I would remove the displayCorrectFiles property entirely and replace it with $io->isVerbose()
There was a problem hiding this comment.
@javiereguiluz I was glad to use it, but it make tests failing as the verbosity methods are available since 3.1 only, dev requirements are to ~2.8|~3.0. Should I up the version bound to ~3.1 for that?
There was a problem hiding this comment.
I'm sorry I didn't think about that. Let's keep the property then, even its use looks so limited.
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Jun 29, 2016
… LintCommand (chalasr) This PR was merged into the 3.2-dev branch. Discussion ---------- [Yaml] Avoid using both Input/Output and SymfonyStyle in LintCommand | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Fixed some inconsistencies/mistakes from the original YamLintCommand. Commits ------- dd84b7f [Yaml] Avoid using both Input/Output and SymfonyStyle in LintCommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some inconsistencies/mistakes from the original YamLintCommand.