Fix the calendar exception to handle null #19691
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the calendar exception to handle null, error was raised while exporting from akeneo The Symfony\Component\Intl\DateFormatter\IntlDateFormatter::__construct() method's argument $calendar value NULL behavior is not implemented. Only the GREGORIAN calendar is supported. Please install the "intl" extension for full localization capabilities. https://cloud.githubusercontent.com/assets/4486133/17287404/81f951cc-57e0-11e6-9f6f-e231bbf00bf4.png
|
This PR should be targeted at 2.7 branch. |
| @@ -143,15 +143,15 @@ class IntlDateFormatter | |||
| * @see http://userguide.icu-project.org/formatparse/datetime | |||
| * | |||
| * @throws MethodArgumentValueNotImplementedException When $locale different than "en" or null is passed | |||
| * @throws MethodArgumentValueNotImplementedException When $calendar different than GREGORIAN is passed | |||
| * @throws MethodArgumentValueNotImplementedException When $calendar different than GREGORIAN is passed or null is passed | |||
There was a problem hiding this comment.
This change is wrong (no exception will be thrown when null is passed).
The docblock that needs to be changed is the @param above.
|
@wakqasahmed can you please add a test case? And ideally rebase on 2.7 also? (and change the base branch here on github as a consequence?) |
|
Submitted new PR (#19751) targeting branch 2.7 and having test case. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the calendar exception to handle null, error was raised while exporting from akeneo
The Symfony\Component\Intl\DateFormatter\IntlDateFormatter::__construct() method's argument $calendar value NULL behavior is not implemented. Only the GREGORIAN calendar is supported. Please install the "intl" extension for full localization capabilities.
https://cloud.githubusercontent.com/assets/4486133/17287404/81f951cc-57e0-11e6-9f6f-e231bbf00bf4.png