Skip to content

Fix invalid parent class reference with PhpUnit 6 #21540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix invalid parent class reference with PhpUnit 6 #21540

wants to merge 1 commit into from

Conversation

advancingu
Copy link

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? possible
Deprecations? no
Tests pass? unknown
Fixed tickets #21534
License MIT
Doc PR

Reopening due to new PhpUnit 4.8.35 that introduces the new namespaces.

See #21534

@nicolas-grekas
Copy link
Member

IMHO, should be submitted against 2.7, with additional changes:

  • change cache-id in phpunit at the root of the repo (to force a rebuild of the phpunit wrapper)
  • add conflict rules for phpunit releases that ship without the BC layer - not only 4.8, but 5.* also
  • update as many underscore-version of PHPUnit_* to namespaced version in all the code base?

@stof
Copy link
Member

stof commented Feb 6, 2017

update as many underscore-version of PHPUnit_* to namespaced version in all the code base?

For our own testsuite, this should be handled separately IMO (when we decide to migrate).

But the bridge and other public base testcases should indeed also be updated IMO

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Feb 6, 2017
@robfrawley
Copy link
Contributor

robfrawley commented Feb 7, 2017 •
edited
Loading

For reference, the conflict rule should include all version of phpunit 5 < 5.4. (changelog)

@xabbuh
Copy link
Member

xabbuh commented Feb 7, 2017

To be more precise, 5.4.0, 5.4.1, and 5.4.2 also don't work as the namespace changed in 5.4.3.

@robfrawley
Copy link
Contributor

robfrawley commented Feb 7, 2017 •
edited
Loading

@xabbuh Only the case was changed between 5.4.0 and 5.4.3. PHP namespaces aren't case sensitive, right?

Edit: Answered my own question: Composer's PSR4 autoloader class map isn't case insensitive.

@peterrehm peterrehm mentioned this pull request Feb 8, 2017
Closed
@peterrehm
Copy link
Contributor

Just provided a PR for this #21564 based on the remarks here.

@fabpot
Copy link
Member

fabpot commented Feb 18, 2017

Closing in favor of #21564

@fabpot fabpot closed this Feb 18, 2017
fabpot added a commit that referenced this pull request Feb 18, 2017
@fabpot
minor #21564 Update to PHPUnit namespaces (peterrehm)
c9684ad 
This PR was squashed before being merged into the 2.7 branch (closes #21564).

Discussion
----------

Update to PHPUnit namespaces

| Q             | A
| ------------- | ---
| Branch?       | 2.7+
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21534
| License       | MIT
| Doc PR        | -

Replaces #21540

@nicolas-grekas Is the update of the cache-id like this sufficient? Do we maybe have to specifiy 4.8.35 in simple-phpunit?

Commits
-------

ddd2dff Update to PHPUnit namespaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Work
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
8 participants
@advancingu @nicolas-grekas @stof @robfrawley @xabbuh @peterrehm @fabpot @carsonbot