Improve tracking of environment variables in the case of private services #21607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @tgalopin. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 14, 2017
…rivate services (tgalopin) This PR was merged into the 3.2 branch. Discussion ---------- Improve tracking of environment variables in the case of private services | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21273 | License | MIT Recently, I stumbled upon an issue with environment variables that I had troubles to understand. Here it is: I have two environment variables, defined in my `parameters.yml` with a default value of empty: ``` yaml parameters: env(MAILJET_PUBLIC_KEY): '' env(MAILJET_PRIVATE_KEY): '' ``` I use these variables only in a private service: ``` xml <service id="app.mailjet.transport" class="AppBundle\Mailjet\MailjetApiTransport" public="false"> <argument type="service" id="csa_guzzle.client.mailjet_api"/> <argument>%env(MAILJET_PUBLIC_KEY)%</argument> <argument>%env(MAILJET_PRIVATE_KEY)%</argument> </service> ``` This private service is not used by any other service for the moment. As the service is private and not used by any other service, the `RemoveUnusedDefinitionsPass` removes it from the container. However, when the container dumper dumps the container, it checks if the environment variable was dumped. As the service is now gone, an expection is thrown (`EnvParameterException, Incompatible use of dynamic environment variables "MAILJET_PUBLIC_KEY", "MAILJET_PRIVATE_KEY" found in parameters.`). Commits ------- f380ba3 Improve tracking of environment variables in the case of private services
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I stumbled upon an issue with environment variables that I had troubles to understand. Here it is:
I have two environment variables, defined in my
parameters.ymlwith a default value of empty:I use these variables only in a private service:
This private service is not used by any other service for the moment.
As the service is private and not used by any other service, the
RemoveUnusedDefinitionsPassremoves it from the container. However, when the container dumper dumps the container, it checks if the environment variable was dumped. As the service is now gone, an expection is thrown (EnvParameterException, Incompatible use of dynamic environment variables "MAILJET_PUBLIC_KEY", "MAILJET_PRIVATE_KEY" found in parameters.).