Skip to content

[Yaml] Fix the tests #21903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2017
Merged

[Yaml] Fix the tests #21903

merged 1 commit into from
Mar 6, 2017

Conversation

GuilhemN
Copy link
Contributor

@GuilhemN GuilhemN commented Mar 6, 2017

Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Fix tests that are currently useless (previously part of #19782).

@fabpot
Copy link
Member

fabpot commented Mar 6, 2017

Thank you @GuilhemN.

@fabpot fabpot merged commit 5107b94 into symfony:2.7 Mar 6, 2017
fabpot added a commit that referenced this pull request Mar 6, 2017
This PR was merged into the 2.7 branch.

Discussion
----------

[Yaml] Fix the tests

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Fix tests that are currently useless (previously part of #19782).

Commits
-------

5107b94 [Yaml] Fix the tests
@GuilhemN GuilhemN deleted the TESTS branch March 7, 2017 06:11
nicolas-grekas added a commit that referenced this pull request Mar 7, 2017
This PR was merged into the 3.2 branch.

Discussion
----------

[Yaml] dump escape sequences when possible

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Tests for them have been introduced in #21903 (in 2.7 and 2.8 this does not need to be fixed as those versions didn't dump the `!!binary` tag).

Commits
-------

997103d [Yaml] dump escape sequences when possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants