[FrameworkBundle] Fix autoloader in insulated clients #21922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
client-fix
branch
from
c9fccf1 to
414ac5d
Compare
stof
reviewed
Mar 8, 2017
| } | ||
|
|
||
| $path = str_replace("'", "\\'", $r->getFileName()); | ||
| $requires .= "require_once '".str_replace("'", "\\'", (new \ReflectionObject($this->kernel))->getFileName())."';\n"; |
There was a problem hiding this comment.
wouldn't var_export be better than doing manual escaping ? Thus, the escaping is incomplete in case there is a \ just before a quote
There was a problem hiding this comment.
Dunno :) Currently, this is consistent with other places (HttpKernel's Client) and with the previous code. I don't see the need to diverge here (in this PR).
fabpot
added a commit
that referenced
this pull request
Mar 8, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [travis] Test with hhvm 3.18 | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21900 | License | MIT | Doc PR | - Needs #21922 on master to be green also. Works around facebook/hhvm#7722. Commits ------- 7f1f0cb [travis] Test with hhvm 3.18
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Mar 8, 2017
…olas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] Fix autoloader in insulated clients | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Related to the deprecation of the class loader component: the `Client` already uses this code in `HttpKernel`, but `FrameworkBundle` is missing the same update. Spotted while debugging the hhvm 3.18 issue (the chain is: `ComposerResource` sees different vendors, thus says the kernel cache is not fresh, thus it is rebuild, thus we hit facebook/hhvm#7722). Commits ------- 414ac5d [FrameworkBundle] Fix autoloader in insulated clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the deprecation of the class loader component:
the
Clientalready uses this code inHttpKernel, butFrameworkBundleis missing the same update.Spotted while debugging the hhvm 3.18 issue (the chain is:
ComposerResourcesees different vendors, thus says the kernel cache is not fresh, thus it is rebuild, thus we hit facebook/hhvm#7722).