Use PHPUnit 5.4 instead of 5.3 #21946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPUnit 5.3 doesn't have the forward compatibility layer for PHPUnit 6 so that `PHPUnit\Framework\TestCase` can be used instead of `PHPUnit_Framework_TestCase`. This generates an error when upgrading to Symfony 3.2.5 without forcing the `SYMFONY_PHPUNIT_VERSION` const: ``` Class 'PHPUnit\Framework\TestCase' not found in vendor/symfony/symfony/src/Symfony/Bundle/FrameworkBundle/Test/KernelTestCase.php on line 25 ``` This was introduced by c9684ad in 3.2.5
greg0ire
approved these changes
Mar 9, 2017
|
Thank you @j0k3r. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 9, 2017
This PR was merged into the 3.2 branch. Discussion ---------- Use PHPUnit 5.4 instead of 5.3 | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | PHPUnit 5.3 doesn't have the forward compatibility layer for PHPUnit 6 so that `PHPUnit\Framework\TestCase` can be used instead of `PHPUnit_Framework_TestCase`. This generates an error when upgrading to Symfony 3.2.5 without forcing the `SYMFONY_PHPUNIT_VERSION` const: ``` Class 'PHPUnit\Framework\TestCase' not found in vendor/symfony/symfony/src/Symfony/Bundle/FrameworkBundle/Test/KernelTestCase.php on line 25 ``` This was introduced by c9684ad (from #21564) in 3.2.5 (Discussion started on Slack: https://symfony-devs.slack.com/archives/support/p1489058629011510) Commits ------- fca16ba Use PHPUnit 5.4 instead of 5.3
Merged
|
3.2.6 released with this patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit 5.3 doesn't have the forward compatibility layer for PHPUnit 6 so that
PHPUnit\Framework\TestCasecan be used instead ofPHPUnit_Framework_TestCase.This generates an error when upgrading to Symfony 3.2.5 without forcing the
SYMFONY_PHPUNIT_VERSIONconst:This was introduced by c9684ad (from #21564) in 3.2.5
(Discussion started on Slack: https://symfony-devs.slack.com/archives/support/p1489058629011510)