[Console] Allow terminal dimensions to be set to 0 (unbounded) #22377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncan3dc
force-pushed
the
zero-console-dimensions
branch
from
b8d968f to
469cff2
Compare
|
@nicolas-grekas are we sure that the existing code treats 0 as unbounded though ? |
|
For formatting exceptions it does, although not technically "unbounded" I guess ( |
|
@duncan3dc yeah, fine enough 😄 |
duncan3dc
force-pushed
the
zero-console-dimensions
branch
from
469cff2 to
4c1b001
Compare
|
Thank you @duncan3dc. |
fabpot
added a commit
that referenced
this pull request
Apr 11, 2017
…ded) (duncan3dc) This PR was merged into the 3.2 branch. Discussion ---------- [Console] Allow terminal dimensions to be set to 0 (unbounded) | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21513 | License | MIT A previous PR (#20328) changed the behavior of terminals with undefined widths from unbounded to 80 characters. And due to the way the existing code worked it become impossible to set a terminal to be unbounded again. This PR provides a way to restore the previous behavior: ```php putenv('COLUMNS=0'); ``` Commits ------- 4c1b001 Allow terminal dimensions to be set to 0 (unbounded)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous PR (#20328) changed the behavior of terminals with undefined widths from unbounded to 80 characters. And due to the way the existing code worked it become impossible to set a terminal to be unbounded again. This PR provides a way to restore the previous behavior: