[SecurityBundle] Allow for custom request matchers in access control #22578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing in favor of doing it in PHP at the class level. This makes config unnecessarily more complex for little gain; a request matcher per route wont help me really. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opening #20272 in the same spirit of #22572, and i have no better solution to enable route matching :)
Not sure about the config yet, it differs from the logout listener where both configs (path + request_matcher) must match.
So for access control to get the same behavior (where all configs must match) it needs a chain request matcher or get creative with
AccessMap::add.Otherwise i think the logout listener should follow this behavior.