[DI] Exclude inline services declared in XML from autowiring candidates #24491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
autow-no-inline
branch
from
3bef6b3 to
d90e721
Compare
xabbuh
reviewed
Oct 8, 2017
| @@ -345,7 +345,7 @@ private function populateAvailableType($id, Definition $definition) | |||
| unset($this->ambiguousServiceTypes[$type]); | |||
| } | |||
|
|
|||
| if ($definition->isDeprecated() || !$reflectionClass = $this->container->getReflectionClass($definition->getClass(), false)) { | |||
| if (preg_match('/^\d+_[^~]++~[._a-zA-Z\d]{7}$/', $id) || $definition->isDeprecated() || !$reflectionClass = $this->container->getReflectionClass($definition->getClass(), false)) { | |||
There was a problem hiding this comment.
Do we have such a regex somewhere else? Would it make sense to store it as a reusable const somewhere?
There was a problem hiding this comment.
That's internal to me: I added an integration test ensuring we don't rely on this exact detail, but on the actual behavior. Thus, not sure a const is needed.
xabbuh
approved these changes
Oct 8, 2017
javiereguiluz
approved these changes
Oct 9, 2017
stof
approved these changes
Oct 9, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 9, 2017
…ng candidates (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Exclude inline services declared in XML from autowiring candidates | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24311 | License | MIT | Doc PR | - As reported in #24311, inline services should not be candidates for autowiring. This PR fixes the issue, but is submitted against 3.4 because there is a potential BC break here, for ppl that didn't realize they relied on this (already deprecated) behavior. We *could* not merge this PR and consider the deprecation is fine - but in practice, the WTF is hitting several ppl already AFAIK, so we should close that door IMHO. Commits ------- d90e721 [DI] Exclude inline services declared in XML from autowiring candidates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #24311, inline services should not be candidates for autowiring.
This PR fixes the issue, but is submitted against 3.4 because there is a potential BC break here, for ppl that didn't realize they relied on this (already deprecated) behavior.
We could not merge this PR and consider the deprecation is fine - but in practice, the WTF is hitting several ppl already AFAIK, so we should close that door IMHO.