Add hint in Github pull request template #26580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Mar 18, 2018
carsonbot
added
Status: Reviewed
Status: Needs Work
and removed
Status: Needs Review
Status: Reviewed
labels
fabpot
requested changes
Mar 18, 2018
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -4,7 +4,7 @@ | |||
| | Bug fix? | yes/no | |||
| | New feature? | yes/no <!-- don't forget to update src/**/CHANGELOG.md files --> | |||
| | BC breaks? | no <!-- see https://symfony.com/bc --> | |||
| | Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md files --> | |||
| | Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md and CHANGELOG.md files --> | |||
There was a problem hiding this comment.
This is ambiguous as people must not change the CHANGELOG-*.md in the root directory, but only the ones from the bridge/bundle/component directories.
There was a problem hiding this comment.
Indeed, updated as "New feature?" with src/**/CHANGELOG.md.
fabpot
approved these changes
Mar 18, 2018
|
Thank you @fmata. |
fabpot
added a commit
that referenced
this pull request
Mar 18, 2018
This PR was merged into the 2.7 branch. Discussion ---------- Add hint in Github pull request template | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT I added a deprecation in the code base but I forgot to update the CHANGELOG.md file of the component although I double checked the pull request template of this case. It's trivial but I think it can be a way to save some time for next distracted contributors :) Commits ------- 986f915 add hint in Github pull request template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a deprecation in the code base but I forgot to update the CHANGELOG.md file of the component although I double checked the pull request template of this case.
It's trivial but I think it can be a way to save some time for next distracted contributors :)