[FrameworkBundle] add PHP errors options to XML schema definition #26739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Apr 2, 2018
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| @@ -273,6 +274,11 @@ | |||
| <xsd:attribute name="enabled" type="xsd:boolean" /> | |||
| </xsd:complexType> | |||
|
|
|||
| <xsd:complexType name="php-errors"> | |||
| <xsd:attribute name="log" type="xsd:boolean" /> | |||
There was a problem hiding this comment.
given this should allow bool|int on 4.1, how should the xsd look like there? (to ease merging up to master)
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 2, 2018
…efinition (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] add PHP errors options to XML schema definition | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 7d39bac add PHP errors options to XML schema definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.