[DI] Improve class named servics error message #28057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ro0NL
commented
Jul 25, 2018
ro0NL
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #28006 |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
Tobion
reviewed
Jul 26, 2018
| if (0 === strpos($id, '\\') && 1 < substr_count($id, '\\')) { | ||
| throw new RuntimeException(sprintf( | ||
| 'The definition for "%s" has no class attribute, and appears to reference a ' | ||
| .'class or interface. Please specify the class attribute explicitly or rename ' |
There was a problem hiding this comment.
how about "... or remove the leading backslash by renaming the service to ..." to explain the difference. otherwise it's not obvious what the change actually is.
There was a problem hiding this comment.
agree, will do :) also i was wondering if we should include the why. If so, @nicolas-grekas how would you explain this?
There was a problem hiding this comment.
because it doesn't work otherwise :) no reason to give here
Tobion
approved these changes
Jul 26, 2018
|
Thank you @ro0NL. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 29, 2018
This PR was squashed before being merged into the 3.4 branch (closes #28057). Discussion ---------- [DI] Improve class named servics error message | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #28006 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Commits ------- 61de060 [DI] Improve class named servics error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.