Display validation errors underneath the form widget instead of underneath the label #28088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neath the label (matches official documentation)
|
Yep, is a duplicate. The original change was made due to accessibility concerns, so I would like to wait for feedback by @Nyholm to not add an accessibility regression. |
nicolas-grekas
changed the title
|
/cc @Nyholm |
|
Closing as a duplicate then. We can consider to reopen if it turns out in #27892 that this is the better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR make the validation errors display underneath the actual form widget instead of underneath the label. This ensures that it matches the official documentation found here.
Old layout:
New (correct) layout:
