Skip to content

Display validation errors underneath the form widget instead of underneath the label #28088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

frostieDE
Copy link

@frostieDE frostieDE commented Jul 30, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28086
License MIT
Doc PR ~

The changes in this PR make the validation errors display underneath the actual form widget instead of underneath the label. This ensures that it matches the official documentation found here.

Old layout:
image

New (correct) layout:
image

…neath the label (matches official documentation)
@OskarStark
Copy link
Contributor

Maybe this is a duplicate of #27892

cc @apfelbox

@apfelbox
Copy link
Contributor

Yep, is a duplicate.

The original change was made due to accessibility concerns, so I would like to wait for feedback by @Nyholm to not add an accessibility regression.

@nicolas-grekas nicolas-grekas changed the title Display validation errors underneath the form widget instead of under… Display validation errors underneath the form widget instead of underneath the label Jul 31, 2018
@fabpot
Copy link
Member

fabpot commented Aug 27, 2018

/cc @Nyholm

@chalasr chalasr added this to the 4.1 milestone Sep 11, 2018
@xabbuh
Copy link
Member

xabbuh commented Sep 23, 2018

Closing as a duplicate then. We can consider to reopen if it turns out in #27892 that this is the better solution.

@xabbuh xabbuh closed this Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants