[TwigBridge] Fixed wrong DateTimeType error handling with bootstrap 4 layout #29158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
changed the title
|
Hm, this was introduced as bugfix in #24802. Maybe @ostrolucky can have a look here. |
|
@lowwa132 Can you post the output of script I posted at #24801 (comment)? This should allow us visual inspection your patch doesn't break anything. This layout has been changed plenty of times since then. |
|
This is wrong. Before your change: After your change: |
|
@xabbuh I believe this can be closed as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed wrong DateTimeType error handling with bootstrap_4_layout.html.twig with (
form-controlclass removed)