-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Console] More info returned by AboutCommand #29923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your (first) contribution to Symfony! I'm not sure I understand the purpose of this change. You mentioned that instead of running |
This is a kind pf reverse of what I proposed here #29865. Image yourself in the followig situation:
I guess, an experienced Symfony user like you, never had to ask these kind of questions. But a less experienced, like me, had to. So it might be useful to somebody else. If anybody wonders, why not just show the list of commands - listing bundles instead of commands is better, bacuse the list is shorter. |
but how many users know exactly which bundle provide which command when they don't have these bundles ? And which non-installed bundles should we display in the list ? We would have to hardcode a list in Symfony for that (as that cannot rely on installed things). And then, how do we decide which bundle are allowed to enter that list ? |
I usually do this: |
@stof Yes, the list has to be hardcoded. I included the most common "internal" Symfony bundles, that provide commads. @iltar That's why I thought that maybe modifying To all. I created this PR as a byproduct of another one. It was a quick idea, and seeing your comments, it seems I should have given it more thought. If I don't get any positive reactions, I will close this PR within 24 hours. |
I think this is cool but not necessary for a general purpose framework. Maybe one day, someone makes a command list database in flex servers and we improve CommandNotFoundException class, capable of command and bundle relation find. |
@delirehberi If I understand you correctly, this is a simple version of what you have in mind #29865 |
@przemyslaw-bogusz yes, that is related. But I suggest a command-package relation server for ideal resolution for that problem. The reason of server, hardcoded command-package relation data is not enough for fixing that problem. However, this feature needs internet access. It`s not pretty for error handling. |
This will make AboutCommand display additional information, indicating which basic symfony bundles are installed. For example:
As a consequence, a user will have a general idea about the commands that can be run, without having to go through composer.json, or checking if a command is available by trying something like
php bin/console make:entity --help
.