Poc muted deprecations do not merge #32472
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
poc-muted-deprecations
branch
from
cba444d to
f88e73e
Compare
|
@greg0ire Thank you for working on this. A small suggestion: can you not create a PR for such early work? The best would be to "just" push your branch to your fork and enable Travis on your fork. That way, you would have all the benefits from Travis without creating a PR here. |
|
I didn't realise I could do that, sorry for the noise, and thanks for the tip 👍 I'm deleting my branch since that now there is a PR, it will still make some noise even though it is closed I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.