[Console] allow answer to be trimmed by adding a flag #32731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As explained in your previous PR, this expands the public API and involves code changes for being used. Per semver:
Closing as this does not qualify as a bugfix, thanks for your understanding. |
|
That's fine, I understand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #23210 (comment) we add a new flag in the Question class to be able to not trim the answer.
This is a "backport" request for #31626 - the code is completely backward-compatible, any existing use gets the answer trimmed. So this
setTrimmable(false)ability would only come into effect if someone modifies their code to use it. All existing code using Symfony 3.4 will work without change.I am proposing that this can be called a bug, because without this change the caller does not and cannot get the complete answer. The change here fixes the bug in a backward-compatible way, by preserving the existing
trimbehaviour by default, and providing the option for the caller to disable thetrimbehaviour.(I have got the CI passing in PHP5.* now - so I am resubmitting to at least "document" what code works against 3.4, and maybe get it accepted! Or most likely someone will just close this because it is considered a feature and not allowed for 3.4)