[RFC][Translation] Deprecate resource_files in translator #32735
Conversation
carsonbot
added
Status: Needs Review
RFC
pierredup
force-pushed
the
translation-paths
branch
from
cc6d324 to
f00c4b4
Compare
| /** | ||
| * @dataProvider getDebugModeAndCacheDirCombinations | ||
| * @group legacy | ||
| */ | ||
| public function testResourceFilesOptionLoadsBeforeOtherAddedResources($debug, $enableCache) |
There was a problem hiding this comment.
With these changes, the following option is now unsupported
'resource_files' => ['some_locale' => ['messages.some_locale.loader']]so a work-around will be needed for this scenario (Maybe adding a new option set loaders per locale?)
| /** | ||
| * Constructor. | ||
| * | ||
| * Available options: | ||
| * | ||
| * * cache_dir: The cache directory (or null to disable caching) | ||
| * * debug: Whether to enable debugging or not (false by default) | ||
| * * resource_files: List of translation resources available grouped by locale. |
|
I know for sure that this will impact https://github.com/willdurand/BazingaJsTranslationBundle, which inspects the definition of the translator service to get the list of resources for its translation finder. The new logic would force the bundle to duplicate the whole location of file resources (maybe this indicates a need for a new service in core, so that they can use the same service than the translator rather than duplicating some internal logic). |
Then we should ensure the new logic exposes a way to get the list of resources from the translator cache. @pierredup do you think it possible? |
|
Closing as there is no more activities on this PR (and it cannot be merged as is). Fee free to reopen if you want to finish it. |
The list of resource files is cached by the container at compile time. This means that any change in translation files (adding/removing a file) needs a rebuilt container t take effect.
This PR proposes to deprecate this behaviour and let the translator manage its own resources fully.
This approach is to pass a list of directories to the translator instead, which the translator can use to determine if the cache needs to be rebuilt. Any change in the directories means only the translator cache will be rebuilt while the container cache stays untouched.
The only time the container needs to be rebuilt is when a new translation directory is added (E.G when adding a new bundle).
I'm not 100% sure what effect this will have on 3rd-party bundles (I.E if a bundle explicitly requires this behaviour and can't pass directories instead), so any insights would be appreciated.