Skip to content

[Lock] remove un-needed implements interface #32990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

B-Galati
Copy link
Contributor

@B-Galati B-Galati commented Aug 6, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets null
License MIT
Doc PR not needed

following #32555 it does not look necessary to implement both PersistingStoreInterface and BlockingStoreInterface

@nicolas-grekas nicolas-grekas added this to the next milestone Aug 6, 2019
@nicolas-grekas
Copy link
Member

Thank you @B-Galati.

@nicolas-grekas nicolas-grekas merged commit b8459f7 into symfony:master Aug 6, 2019
nicolas-grekas added a commit that referenced this pull request Aug 6, 2019
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Lock] remove un-needed implements interface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | null
| License       | MIT
| Doc PR        | not needed

following #32555 it does not look necessary to implement both `PersistingStoreInterface` and `BlockingStoreInterface`

Commits
-------

b8459f7 [Lock] remove un-needed implements interface
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants