Skip to content

Update UPGRADE file to indicate method signature changed #33080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Aug 9, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Followup #33048

@jderusse jderusse requested a review from xabbuh as a code owner August 9, 2019 08:20
@nicolas-grekas nicolas-grekas added this to the next milestone Aug 9, 2019
@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 56d5d6d into symfony:4.4 Aug 9, 2019
nicolas-grekas added a commit that referenced this pull request Aug 9, 2019
… (jderusse)

This PR was merged into the 4.4 branch.

Discussion
----------

Update UPGRADE file to indicate method signature changed

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Followup #33048

Commits
-------

56d5d6d Add deprecation for method signature
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
@jderusse jderusse deleted the deprec-changelog branch March 5, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants