[Validator] Add ConstraintValidator::formatValue() tests #33434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
force-pushed
the
validator-test-constraint-validator-format-value
branch
from
78e13ed to
8753531
Compare
OskarStark
reviewed
Sep 2, 2019
| ['"foo"', 'foo'], | ||
| ['array', []], | ||
| ['object', $toString = new TestToStringObject()], | ||
| ['ccc', $toString, ConstraintValidator::OBJECT_TO_STRING], |
There was a problem hiding this comment.
Is it correct, that this test depends on the test before?
There was a problem hiding this comment.
For me, it doesn't really depends of it. It just reuses the same object instance to avoid a new instantiation. It also highlights that the same object is formatted differently depending of the format parameter.
fancyweb
commented
Sep 3, 2019
fancyweb
force-pushed
the
validator-test-constraint-validator-format-value
branch
from
8753531 to
a1771ec
Compare
fancyweb
force-pushed
the
validator-test-constraint-validator-format-value
branch
from
a1771ec to
d695754
Compare
yceruto
reviewed
Sep 3, 2019
src/Symfony/Component/Validator/Tests/ConstraintValidatorTest.php
Outdated
Show resolved
Hide resolved
fancyweb
force-pushed
the
validator-test-constraint-validator-format-value
branch
from
d695754 to
90ffed4
Compare
yceruto
reviewed
Sep 3, 2019
src/Symfony/Component/Validator/Tests/ConstraintValidatorTest.php
Outdated
Show resolved
Hide resolved
fancyweb
force-pushed
the
validator-test-constraint-validator-format-value
branch
from
90ffed4 to
afb8d78
Compare
yceruto
approved these changes
Sep 3, 2019
fabpot
approved these changes
Sep 3, 2019
fabpot
force-pushed
the
validator-test-constraint-validator-format-value
branch
from
afb8d78 to
b688aa3
Compare
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Sep 3, 2019
… (fancyweb) This PR was squashed before being merged into the 3.4 branch (closes #33434). Discussion ---------- [Validator] Add ConstraintValidator::formatValue() tests | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - So #33401 tests can be built on top of this. Commits ------- b688aa3 [Validator] Add ConstraintValidator::formatValue() tests
fancyweb
deleted the
validator-test-constraint-validator-format-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So #33401 tests can be built on top of this.