Skip to content

move abstract test classes to Test namespace #33634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 18, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Sep 18, 2019
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Sep 18, 2019

That doesn't make sense. We added .gitattributes because ppl did not want to get the tests in the zip, yet we're still adding them back?

That's going to cause a lot of troubles in the long run, because we won't be able to know ahead of time when a test should be added to Tests or Test. Process wise, we have no CI to back that up.

I'm seriously in favor of reverting the PR that added those files. We could replace them by some logic in flex instead.

@Nyholm
Copy link
Member

Nyholm commented Sep 18, 2019

Thank you for the PR.

@xabbuh could you elaborate why this is needed?

@fabpot
Copy link
Member

fabpot commented Sep 19, 2019

Maybe adding the .gitattributes in 3.4 was not the right move. We could do it only in 4.4 instead?

@xabbuh
Copy link
Member Author

xabbuh commented Sep 19, 2019

@Nyholm In some bundles/bridges we rely on classes from the Tests namespace of different components. Now, with the changes done in #33579 these classes are not there anymore in our deps=low/deps=high build jobs.

@fabpot Not sure that really helps here. We would have the exact same problem there again I guess.

Another solution could be to install from source instead (see #33637).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants