Skip to content

[String] bytesAt() and codePointsAt() #33940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

gharlan
Copy link
Contributor

@gharlan gharlan commented Oct 9, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #33923
License MIT
Doc PR symfony/symfony-docs/pull/12440

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Oct 11, 2019
@gharlan gharlan changed the title [String] move codePoint() to CodePointString, add codePoints() to UnicodeString [String] bytesAt() and codePointsAt() Oct 11, 2019
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thank you!

@nicolas-grekas
Copy link
Member

Thank you @gharlan.

nicolas-grekas added a commit that referenced this pull request Oct 14, 2019
This PR was merged into the 5.0-dev branch.

Discussion
----------

[String] bytesAt() and codePointsAt()

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #33923
| License       | MIT
| Doc PR        | symfony/symfony-docs/pull/12440

Commits
-------

f8d2faa [String] bytesAt() and codePointsAt()
@nicolas-grekas nicolas-grekas merged commit f8d2faa into symfony:master Oct 14, 2019
@gharlan gharlan deleted the string-codepoint branch October 14, 2019 13:23
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Jan 2, 2020
This PR was merged into the 5.0 branch.

Discussion
----------

[String] Replace codePoint by codePointsAt

symfony/symfony#33940 renamed the `codePoint` method to `codePointsAt`.

Commits
-------

d507793 [String] Replace codePoint by codePointsAt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants